Fix attributes leaking in the toggle switch component #10035

janfaracik · 2024-12-07T19:06:33Z

Small one to fix the attributes leaking in the <f:toggleSwitch /> component. It was missing attrs. which caused some properties to inherit prior set values.

Testing done

Toggle switch works as expected in project views/Design Library

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

krisstern

LGTM

krisstern · 2024-12-08T02:53:50Z

If there is no objection this PR will be merged in 24 hours

Fix toggleswitch attributes

43e0849

janfaracik added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog labels Dec 7, 2024

timja approved these changes Dec 7, 2024

View reviewed changes

timja requested a review from a team December 7, 2024 19:14

krisstern approved these changes Dec 8, 2024

View reviewed changes

krisstern added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 8, 2024

NotMyFault approved these changes Dec 8, 2024

View reviewed changes

krisstern merged commit fa35f03 into jenkinsci:master Dec 9, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix attributes leaking in the toggle switch component #10035

Fix attributes leaking in the toggle switch component #10035

janfaracik commented Dec 7, 2024 •

edited by krisstern

Loading

Submitter checklist

Maintainer checklist

krisstern left a comment

krisstern commented Dec 8, 2024

Fix attributes leaking in the toggle switch component #10035

Fix attributes leaking in the toggle switch component #10035

Conversation

janfaracik commented Dec 7, 2024 • edited by krisstern Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

krisstern left a comment

Choose a reason for hiding this comment

krisstern commented Dec 8, 2024

janfaracik commented Dec 7, 2024 •

edited by krisstern

Loading